Repository navigation
fix(breath): clamp negative stage durations - #1436
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Aligns Android breath-stage duration handling with Swift by normalizing negative stage durations to zero at construction time.
The Kotlin model remains immutable and retains its data-class value semantics. Mirrored Swift and Kotlin regression tests verify the stored duration, zero cycle duration, and empty scheduling result for a negative stage.
This addresses only the negative-duration parity finding in bhelm#32. The other findings in that issue remain out of scope.
Type of change
How it was tested
cd Packages/StrandAnalytics && swift test --filter BreathProtocolPlayerTests— 7 tests passedcd android && ./gradlew :app:testFullDebugUnitTest --tests "com.noop.analytics.BreathProtocolPlayerTest" --no-daemon --max-workers=1 --no-parallel— 7 tests passedOnly the focused suites were run. No manual, device, or strap testing was performed; the behavior is covered by deterministic unit fixtures.
Checklist
swift testinPackages/<name>) — focusedBreathProtocolPlayerTestspassed; the full package suite was not runandroid/(./gradlew testFullDebugUnitTest) — focusedBreathProtocolPlayerTestpassed; the full Android suite was not runStrandDesigntokens — not applicable; no UI changeddocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
Related: bhelm#32